cleanup temporary files, use prefix "jabref-" #7811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koppor
approved these changes
Jun 10, 2021
| @@ -305,11 +305,12 @@ public Path toTemporaryFile() throws IOException { | |||
|
|
|||
| // Take everything after the last '/' as name + extension | |||
| String fileNameWithExtension = sourcePath.substring(sourcePath.lastIndexOf('/') + 1); | |||
| String fileName = FileUtil.getBaseName(fileNameWithExtension); | |||
| String fileName = "jabref-" + FileUtil.getBaseName(fileNameWithExtension); | |||
There was a problem hiding this comment.
I had to think long about this. Since its a temporary file anyway, the filename doesn't matter. Thus, good to go!
calixtus
approved these changes
Jun 10, 2021
Siedlerchr
added a commit
to JabRef/jabref-koppor
that referenced
this pull request
Jun 16, 2021
* upstream/main: Added auto-key-generation task to task-progress (JabRef#7797) cleanup temporary files, use prefix "jabref-" (JabRef#7811) Add easier how-to for checklist (JabRef#7813) Fix annotation + package of ACMPortalParserTest (JabRef#7812) Implemented a select all button for the library import function (issue JabRef#7786) (JabRef#7808) Fix for issue 4682 : Restructuring the side pane structure having additional functionality and merging the remove group menus (JabRef#7714)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Now:
and which program should not run while removing
Change in
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)NA
Tests created for changes (if applicable)
NA
[X ] Manually tested changed features in running JabRef (always required)
Screenshots added in PR description (for UI changes)
NA
Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.
NA